Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize implementation for spark reader #52

Merged
merged 6 commits into from
Dec 30, 2022

Conversation

lixueclaire
Copy link
Contributor

@lixueclaire lixueclaire commented Dec 23, 2022

Proposed changes

Initialize implementation for spark readers, which could read GAR files into Spark DataFrame.

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Fixed issue: #29

@acezen
Copy link
Contributor

acezen commented Dec 29, 2022

LGTM

@lixueclaire lixueclaire merged commit 36f6b78 into apache:main Dec 30, 2022
@lixueclaire lixueclaire deleted the 29-spark-reader branch December 30, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants