This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
HAWQ-1276. The error message is not friendly when ranger plugin servi… #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce is unavailable.
wcl14
reviewed
Jan 16, 2017
| @@ -366,7 +365,7 @@ static size_t write_callback(char *contents, size_t size, size_t nitems, | |||
| if (curl->response.buffer == NULL) | |||
| { | |||
| /* out of memory! */ | |||
| elog(WARNING, "not enough memory for Ranger response"); | |||
| elog(WARNING, "cannot allocate memory for ranger response"); | |||
There was a problem hiding this comment.
Why do you modify the out of memory error message. I think the original one is more specified, and may be better.
There was a problem hiding this comment.
hmm, IMO , not enough memory is not the only error that will occur. There maybe other errors in the repalloc implementation. So I changed the messages.
There was a problem hiding this comment.
So should the comment be consistent with the code?
|
+1 |
linwen
reviewed
Jan 17, 2017
| @@ -294,7 +294,7 @@ static json_object *create_ranger_request_json(List *request_list, List *result_ | |||
| break; | |||
| } | |||
| default: | |||
| elog(ERROR, "unrecognized objkind: %d", (int) kind); | |||
| elog(ERROR, "unrecognized object kind : %d", (int) kind); | |||
There was a problem hiding this comment.
since this is a message to users, we should map this "kind" to string, so that users can know which kind is not supported.
|
merged into master. closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ce is unavailable.