Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

[healthmgr] heron-aurora-scheduler.jar is needed in healthmgr #2873

Open
huijunw opened this issue Apr 24, 2018 · 4 comments
Open

[healthmgr] heron-aurora-scheduler.jar is needed in healthmgr #2873

huijunw opened this issue Apr 24, 2018 · 4 comments

Comments

@huijunw
Copy link
Contributor

huijunw commented Apr 24, 2018

The present heron-core.tar.gz does not include heron-aurora-scheduler.jar file. This jar file is needed in https://github.com/apache/incubator-heron/blob/master/heron/healthmgr/src/java/org/apache/heron/healthmgr/HealthManager.java#L394

auroraerror

@ashvina
Copy link
Contributor

ashvina commented Apr 25, 2018

heron-core does not contains yarn or aurora scheduler (https://github.com/apache/incubator-heron/blob/master/tools/rules/heron_core.bzl#L37). To me it seems it should not contain any other schedulers too. The executor does not need any scheduler jars, since the scheduler starts before executors and the scheduler itself launches all the executors. When scheduler is running as a service it is contacted using scheduler independent http calls. In the other non-service cases, the scheduler is embedded in the client (https://github.com/apache/incubator-heron/blob/master/tools/rules/heron_client.bzl#L32). Perhaps this needs to be asked in a new issue.
@maosongfu, @kramasamy, @neng WDYT?

w.r.t. this issue, the solution would be add the non-service scheduler (aurora in this case) to the healthmgr jar. However I am not sure if inclusion of aurora jar is sufficient. Any files needed by aurora scheduler need to be present on container-0. Is that feasible?
@huijunw Are you able to run the healthmgr in container-0

@kramasamy
Copy link
Contributor

I agree - introducing scheduler dependency into heron core - is not a good idea.

@huijunw huijunw changed the title [healthmgr] heron-aurora-scheduler.jar is needed in heron-core.tar.gz [healthmgr] heron-aurora-scheduler.jar is needed in healthmgr Apr 26, 2018
@huijunw
Copy link
Contributor Author

huijunw commented Apr 26, 2018

as long as heron-aurora-scheduler.jar is available in class path for healthmgr, it is fine to me.

@kramasamy
Copy link
Contributor

@huijunw - can you explain why Aurora scheduler jar is needed in the core - not clear why?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants