This repository has been archived by the owner on Sep 20, 2022. It is now read-only.
[HIVEMALL-142] Implement SingularizeUDF #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takuti
commented
Aug 28, 2017
| @@ -172,12 +172,17 @@ public static void clear(@Nonnull final StringBuilder buf) { | |||
|
|
|||
| public static String concat(@Nonnull final List<String> list, @Nonnull final String sep) { | |||
There was a problem hiding this comment.
@myui I guess you originally assumed this method behaves in a similar way to what org.apache.commons.lang3.StringUtils.join does. However, the original code appends a separator even at the end of result string as:
- expected:
concat(["a", "b", "c"], "-")=>a-b-c - actual:
concat(["a", "b", "c"], "-")=>a-b-c-
So, I fixed the method in 796d388. Is this okay? If my assumption was incorrect, I revert the modification and introduce alternative method StringUtils.join().
There was a problem hiding this comment.
okay, so I revert and create join method here
This behavior is similar to org.apache.commons.lang3.StringUtils.join
|
👍 Merged. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement
singularize(string word)to obtain singular form ofword.The implementation referred the following third-party code:
What type of PR is it?
Feature
What is the Jira issue?
https://issues.apache.org/jira/browse/HIVEMALL-142
How was this patch tested?
unit test & manual test on EMR
How to use this feature?
as documented
Checklist
mvn formatter:format, for your commit?