This repository has been archived by the owner on Sep 20, 2022. It is now read-only.
[HIVEMALL-124][BUGFIX] Fixed bugs in BinaryResponseMeasure (nDCG, MRR, AP) #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@takuti could you review this PR? |
takuti
reviewed
Sep 15, 2017
| } | ||
| return 0.d; | ||
| } | ||
| final int k = Math.min(rankedList.size(), recommendSize); |
There was a problem hiding this comment.
Computing Math.min(rankedList.size(), recommendSize) twice at here and inside of TruePositives looks redundant and a little bit confusing. For the sake of simplicity, how about directly writing what TruePositives does both in Precision and Recall, and remove TruePositives? Even though the same for-loop appears twice, I personally feel it's much more easier to understand.
There was a problem hiding this comment.
Fixed in 759b088
Recall is as it is.
| if (nTruePositive == 0) { | ||
| return 0.d; | ||
| } | ||
| return sumPrecision / nTruePositive; |
|
Ideally, it should be |
myui
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixed bug in the BinaryResponse measure such as nDCG, MRR, (M)AP.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/HIVEMALL-124
How was this patch tested?
unit tests, manual tests
Checklist
mvn formatter:format, for your commit?