This repository has been archived by the owner on Sep 20, 2022. It is now read-only.
[HIVEMALL-192] Fix typos: graphvis -> graphviz #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myui
suggested changes
Apr 18, 2018
|
|
||
| @Nonnull | ||
| public static OutputType resolve(@Nonnull String name) throws UDFArgumentException { | ||
| if ("js".equalsIgnoreCase(name) || "javascript".equalsIgnoreCase(name)) { | ||
| return javascript; | ||
| } else if ("dot".equalsIgnoreCase(name) || "graphvis".equalsIgnoreCase(name)) { | ||
| return graphvis; | ||
| } else if ("dot".equalsIgnoreCase(name) || "graphviz".equalsIgnoreCase(name)) { |
There was a problem hiding this comment.
better to have "graphvis".equalsIgnoreCase(name) for backward compatibility.
There was a problem hiding this comment.
if("dot".equalsIgnoreCase(name) || "graphviz".equalsIgnoreCase(name) || "graphvis".equalsIgnoreCase(name))
|
@takuti LGTM! You can merge this PR. |
myui
approved these changes
Apr 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix crucial typos.
What type of PR is it?
Improvement
What is the Jira issue?
https://issues.apache.org/jira/browse/HIVEMALL-192
Checklist
mvn formatter:format, for your commit?