This repository has been archived by the owner on Sep 20, 2022. It is now read-only.
[HIVEMALL-90] Refine incomplete AUC UDAF implementation #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myui
reviewed
Apr 9, 2017
| long fp = PrimitiveObjectInspectorFactory.writableLongObjectInspector.get(fpObj); | ||
| long tp = PrimitiveObjectInspectorFactory.writableLongObjectInspector.get(tpObj); | ||
| long fpPrev = PrimitiveObjectInspectorFactory.writableLongObjectInspector.get(fpPrevObj); | ||
| long tpPrev = PrimitiveObjectInspectorFactory.writableLongObjectInspector.get(tpPrevObj); | ||
|
|
||
| Map<Double, Double> areaPartialMap = (Map<Double, Double>) ObjectInspectorFactory.getStandardMapObjectInspector( |
There was a problem hiding this comment.
ObjectInspectorFactory.getStandardMapObjectInspector(
PrimitiveObjectInspectorFactory.writableDoubleObjectInspector,
PrimitiveObjectInspectorFactory.writableLongObjectInspector
)Invalid casting Map<DoubleWritable, LongWritable> to Map<Double, Double>
| @@ -35,7 +39,9 @@ | |||
| import org.apache.hadoop.hive.ql.udf.generic.GenericUDAFEvaluator; | |||
| import org.apache.hadoop.hive.ql.udf.generic.GenericUDAFEvaluator.AbstractAggregationBuffer; | |||
| import org.apache.hadoop.hive.serde2.io.DoubleWritable; | |||
| import org.apache.hadoop.hive.serde2.lazybinary.LazyBinaryMap; | |||
| PrimitiveObjectInspectorFactory.writableLongObjectInspector).getMap( | ||
| HiveUtils.castLazyBinaryObject(areaPartialMapObj)); | ||
|
|
||
| Map<Double, Long> fpPartialMap = (Map<Double, Long>) ObjectInspectorFactory.getStandardMapObjectInspector( |
There was a problem hiding this comment.
TerminatePartial returns Writable objects but receiving Java objects.
| partialResult[2] = new LongWritable(myAggr.fp); | ||
| partialResult[3] = new LongWritable(myAggr.tp); | ||
| partialResult[4] = new LongWritable(myAggr.fpPrev); | ||
| partialResult[5] = new LongWritable(myAggr.tpPrev); | ||
| partialResult[6] = myAggr.areaPartialMap; |
There was a problem hiding this comment.
revise OI. javaDoubleObjectInspector instead of writableDoubleObjectInspector?
|
@takuti terminatePartial/merge OIs are invalid ones. |
|
@myui fixed. plz check them. |
|
@takuti LGTM. Merged to small modifications. Thanks! |
takuti
added a commit
to takuti/incubator-hivemall
that referenced
this pull request
Apr 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Since AUC UDAF (classification) did not work correctly for some specific merge orders, this PR fixes the issue by modifying the UDAF's
merge()andterminate()implementation.Moreover, unit tests are refined accordingly, and a utility method is created in HiveUtils.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/HIVEMALL-90
How was this patch tested?
How to use this feature?
Nothing has been changed from current AUC UDAF.