[HIVEMALL-84-3] Update docker-compose.yml and documents #81
Conversation
|
@amaya382 could you check this if you get a chance? |
| 3. `docker run -p 8088:8088 -p 50070:50070 -p 19888:19888 -it hivemall/latest:20170517` | ||
| Refer [Docker reference](https://docs.docker.com/engine/reference/run/) for the command detail. | ||
|
|
||
| Similarly to the `volumes` option in the `docker-compose` file, `docker run` has `--volumes` option: |
There was a problem hiding this comment.
typo --volume. as an other choice, -v would be easier
|
|
||
| You can find pre-built Hivemall docker images in [this repository](https://hub.docker.com/r/hivemall/latest/). | ||
|
|
||
| 1. Check [the latest tag](https://hub.docker.com/r/hivemall/latest/tags/) first |
There was a problem hiding this comment.
This repository is in the wrong way, must be fixed its name as hivemall and its tag as version ({owner}/{repository}:{tag}, like hivemall/hivemall:latest or hivemall/hivemall:0.4.2-rc.2).
And if distribute image via dokcerhub, we should prepare automated build to retain consistency and integrity.
There was a problem hiding this comment.
Or, if @amaya382 can set up this, it would be nice after this PR has been merged.
There was a problem hiding this comment.
owner is used for repository.
repository is used for branch.
tag is used for versioning.
hivemall:release:v0.5-rc.1
hivemall:lastest:20170502-1
hivemall:spark:20170501
owner: hivemall is used only for hivemall. hivemall:hivemall is redundant. So, okey as it is.
There was a problem hiding this comment.
It's redundant but depart from docker's usual practice...
e.g.
- automated build uses branch or tag (on git) as tag (on docker)
- if become an official repository or under apache, its name will be broken
There was a problem hiding this comment.
I'll ask for ASF INFRA to get an access to https://hub.docker.com/u/apache/
There was a problem hiding this comment.
@amaya382 @takuti official Dockerhub can only be used for official Apache releases.
See discussions in
https://issues.apache.org/jira/browse/INFRA-14123?jql=project%20%3D%20INFRA%20AND%20text%20~%20dockerhub
Unofficial docker images better not be advertised officially...
There was a problem hiding this comment.
It seems better to distribute TAGGED images on docker hub (apache/hivemall) by automated build and distributing NOT TAGGED ones should depend on manual build from Dockerfile.
(The former for evaluation by user, the latter for developer)
http://www.apache.org/dev/release-distribution.html#unreleased
There was a problem hiding this comment.
We can only publish TAGGED image associated with ASF official release. Release for each commit is not allowed in ASF distribution policies.
|
|
||
| > #### Note | ||
| > You can [skip](./getting_started.html#running-pre-built-docker-image-in-dockerhub) building images by using existing Docker images. | ||
| > You can [skip](./getting_started.html#running-pre-built-docker-image-in-dockerhub) building images by using a pre-build docker image from Docker Hub. |
|
@amaya382 Fixed document, thanks! |
1 similar comment
|
Even only for release, it sounds nice. Let's try it in the next (first) apache release if possible :) For now, I've updated the description of the Docker Hub image. I keep the part, but mentioned that the distributed image might be out-of-data. Is it okay for you @myui @amaya382 ? In terms of naming, it should be re-considered when we officially distribute an image according to ASF release. |
|
@takuti looks good! |
|
@myui ^ everything is okay? |
|
will check soon. |
|
LGTM. Merged to master. Thanks! |
What changes were proposed in this pull request?
I tried things written in the Docker on Hivemall documentation and noticed a couple of things we can improve.
docker-compose.ymlto behave in a similar manner todocker runWhat type of PR is it?
Documentation
What is the Jira issue?
https://issues.apache.org/jira/browse/HIVEMALL-84
How was this patch tested?
Manually