Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

chore: add toml config parser #101

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Conversation

ZuLiangWang
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

At present, ceresmeta's startup parameters only support specifying in program arguments. These configurations are difficult to maintain. We want to specify startup parameters by setting configuration files.

What changes are included in this PR?

  • Add toml config parser, it will parse toml config when ceresmeta starts.
  • Add a sample toml config example.

Are there any user-facing changes?

User can configure the startup parameters by input toml file path now.

How does this change test

Local manual test.

server/config/config.go Outdated Show resolved Hide resolved
server/config/config.go Outdated Show resolved Hide resolved
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit 7631ccf into apache:main Nov 17, 2022
ZuLiangWang added a commit to ZuLiangWang/ceresmeta that referenced this pull request Nov 25, 2022
* chore: add toml config parser

* chrome: add toml config parser
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants