Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

fix: fix http server start #102

Merged
merged 3 commits into from
Nov 18, 2022
Merged

Conversation

ZuLiangWang
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

Now the http server will be started when the meta starts synchronously, this will cause the meta server to fail to initialize normally.

What changes are included in this PR?

  • Change the start of http server from synchronous to asynchronous.

Are there any user-facing changes?

None.

How does this change test

Local manual test.

server/server.go Outdated Show resolved Hide resolved
server/server.go Show resolved Hide resolved
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit 7948618 into apache:main Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants