Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

feat: parse config from env #112

Merged
merged 2 commits into from
Nov 28, 2022
Merged

feat: parse config from env #112

merged 2 commits into from
Nov 28, 2022

Conversation

ZuLiangWang
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

The special character '-' is not allowed in the environment variable, so the previous reading method of the environment variable needs to be adjusted.

What changes are included in this PR?

Are there any user-facing changes?

The server could be started through the environment variable.

How does this change test

Local manual test.

server/config/config.go Outdated Show resolved Hide resolved
Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 changed the title feat: add env variables parse feat: parse config from env Nov 28, 2022
@chunshao90 chunshao90 merged commit a18992a into apache:main Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants