Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

feat: add etcd max txn ops config #120

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

ZuLiangWang
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

Because of the limitation of etcd on single txn ops (128 by default), when the cluster is configured with a large number of shards, etcd will fail to write. Therefore, it is necessary to provide a configuration entry to adjust the maxTxnOps.

What changes are included in this PR?

  • Add EtcdMaxTxnOps in start config.
  • Start etcd server with EtcdMaxTxnOps.

Are there any user-facing changes?

None.

How does this change test

@codecov-commenter
Copy link

Codecov Report

Merging #120 (e40aed3) into main (423ca15) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   39.80%   39.80%           
=======================================
  Files          29       29           
  Lines        3432     3432           
=======================================
  Hits         1366     1366           
  Misses       1882     1882           
  Partials      184      184           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 merged commit 0b53241 into apache:main Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants