Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

feat: add create partition table procedure #123

Merged
merged 6 commits into from
Dec 23, 2022

Conversation

ZuLiangWang
Copy link
Contributor

@ZuLiangWang ZuLiangWang commented Dec 19, 2022

Which issue does this PR close?

(apache/horaedb#492)

Rationale for this change

Support create partition table in CeresDB.

What changes are included in this PR?

  • Add implementation of CreatePartitionTableProcedure.
  • Add ShardPicker for picking up the shards suitable for scheduling in the cluster.

Are there any user-facing changes?

None.

How does this change test

Pass unit test.

@ZuLiangWang ZuLiangWang force-pushed the create_partition_table branch 2 times, most recently from 3732a23 to 957ce05 Compare December 19, 2022 11:13
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2022

Codecov Report

Merging #123 (c8e01a2) into main (423ca15) will decrease coverage by 0.26%.
The diff coverage is 40.76%.

❗ Current head c8e01a2 differs from pull request most recent head 2b57e5e. Consider uploading reports for the commit 2b57e5e to get more accurate results

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   39.80%   39.54%   -0.27%     
==========================================
  Files          29       33       +4     
  Lines        3432     3786     +354     
==========================================
+ Hits         1366     1497     +131     
- Misses       1882     2075     +193     
- Partials      184      214      +30     
Impacted Files Coverage Δ
server/cluster/cluster.go 0.00% <0.00%> (ø)
server/cluster/manager.go 0.00% <0.00%> (ø)
server/cluster/table_manager.go 0.00% <0.00%> (ø)
server/cluster/types.go 0.00% <ø> (ø)
server/coordinator/procedure/create_table.go 0.00% <0.00%> (-53.39%) ⬇️
server/coordinator/procedure/factory.go 0.00% <0.00%> (ø)
server/coordinator/procedure/transfer_leader.go 49.52% <ø> (ø)
server/coordinator/procedure/util.go 38.88% <40.00%> (+0.17%) ⬆️
...er/coordinator/procedure/create_partition_table.go 43.26% <43.26%> (ø)
...erver/coordinator/procedure/create_normal_table.go 46.57% <46.57%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ZuLiangWang ZuLiangWang force-pushed the create_partition_table branch 3 times, most recently from 9010322 to e3e2ea2 Compare December 19, 2022 12:50
server/cluster/manager.go Outdated Show resolved Hide resolved
server/cluster/manager.go Outdated Show resolved Hide resolved
server/coordinator/procedure/ShardPicker.go Outdated Show resolved Hide resolved
server/storage/types.go Outdated Show resolved Hide resolved
server/service/grpc/service.go Outdated Show resolved Hide resolved
server/cluster/table_manager_test.go Outdated Show resolved Hide resolved
server/coordinator/procedure/ShardPicker.go Outdated Show resolved Hide resolved
server/coordinator/procedure/ShardPicker.go Outdated Show resolved Hide resolved
server/coordinator/procedure/ShardPicker.go Outdated Show resolved Hide resolved
server/coordinator/procedure/ShardPicker.go Outdated Show resolved Hide resolved
server/coordinator/procedure/ShardPicker.go Outdated Show resolved Hide resolved
server/coordinator/procedure/create_partition_table.go Outdated Show resolved Hide resolved
server/coordinator/procedure/factory.go Outdated Show resolved Hide resolved
@ZuLiangWang ZuLiangWang force-pushed the create_partition_table branch 3 times, most recently from 6fe0874 to 89697f2 Compare December 23, 2022 05:43
server/cluster/types.go Outdated Show resolved Hide resolved
server/cluster/table_manager_test.go Show resolved Hide resolved
server/config/config.go Outdated Show resolved Hide resolved
@ZuLiangWang ZuLiangWang force-pushed the create_partition_table branch 2 times, most recently from 49b63b7 to b70af64 Compare December 23, 2022 09:41
server/config/config.go Outdated Show resolved Hide resolved
server/coordinator/procedure/factory.go Outdated Show resolved Hide resolved
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZuLiangWang ZuLiangWang merged commit 225891b into apache:main Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants