This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
feat: add create partition table procedure #123
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3732a23
to
957ce05
Compare
Codecov Report
@@ Coverage Diff @@
## main #123 +/- ##
==========================================
- Coverage 39.80% 39.54% -0.27%
==========================================
Files 29 33 +4
Lines 3432 3786 +354
==========================================
+ Hits 1366 1497 +131
- Misses 1882 2075 +193
- Partials 184 214 +30
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
9010322
to
e3e2ea2
Compare
e3e2ea2
to
bf48d36
Compare
chunshao90
reviewed
Dec 20, 2022
82f3aab
to
fccdd7c
Compare
ShiKaiWi
reviewed
Dec 20, 2022
461226f
to
18514f2
Compare
ShiKaiWi
reviewed
Dec 20, 2022
6fe0874
to
89697f2
Compare
89697f2
to
d047910
Compare
ShiKaiWi
reviewed
Dec 23, 2022
154f88d
to
2c537ce
Compare
ShiKaiWi
reviewed
Dec 23, 2022
a56d10f
to
2cc754f
Compare
ShiKaiWi
reviewed
Dec 23, 2022
49b63b7
to
b70af64
Compare
ShiKaiWi
reviewed
Dec 23, 2022
b70af64
to
c8e01a2
Compare
ShiKaiWi
reviewed
Dec 23, 2022
ShiKaiWi
approved these changes
Dec 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
(apache/horaedb#492)
Rationale for this change
Support create partition table in CeresDB.
What changes are included in this PR?
CreatePartitionTableProcedure
.ShardPicker
for picking up the shards suitable for scheduling in the cluster.Are there any user-facing changes?
None.
How does this change test
Pass unit test.