This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
refactor: replace reopen shard with open table #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZuLiangWang
force-pushed
the
reopen_shard
branch
from
0363a0f
to
9c6383d
Compare
Codecov Report
@@ Coverage Diff @@
## main #129 +/- ##
==========================================
- Coverage 39.80% 39.07% -0.73%
==========================================
Files 29 33 +4
Lines 3432 4217 +785
==========================================
+ Hits 1366 1648 +282
- Misses 1882 2317 +435
- Partials 184 252 +68
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ZuLiangWang
force-pushed
the
reopen_shard
branch
2 times, most recently
from
f4f091c
to
c979a9c
Compare
ShiKaiWi
reviewed
Jan 12, 2023
ZuLiangWang
force-pushed
the
reopen_shard
branch
from
c979a9c
to
05aecc7
Compare
ShiKaiWi
reviewed
Jan 13, 2023
ZuLiangWang
force-pushed
the
reopen_shard
branch
from
d4adfd7
to
d5f1218
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
When creating partition table, CeresMeta need to open tables on multiple shards, but CeresDB only supports open/close shard interface, so we implement open table by reopen shard. This is an inefficient way, which will cause shard to be unavailable during table creation. It's should be replaced with open table after CeresDB provides new interface.
What changes are included in this PR?
OpenTableOnShardimplementation inDispatchImpl.CloseShardandOpenShardwithOpenTableOnShard.UpdateShardVersioninDropPartitionTableProcedure.Are there any user-facing changes?
Shard can work normally when creating/drop partition tables.
How does this change test
Pass existing unit tests.