Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

fix: add node state check in transfer leader procedure & Support multi-node concurrent shard opening. #134

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

ZuLiangWang
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

Fix the scheduling and failover bugs found in recent use.

What changes are included in this PR?

  • Add node state check in TransferLeaderProcedure.
  • Support multi-node concurrent shard opening to speed up replay.
  • Add getShardNodes interface.

Are there any user-facing changes?

None.

How does this change test

Pass existing unit tests.

add node parallelism in scheduler

add getShardNodes interface
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Merging #134 (d9a196b) into main (494e15e) will decrease coverage by 1.54%.
The diff coverage is 51.24%.

❗ Current head d9a196b differs from pull request most recent head 33146af. Consider uploading reports for the commit 33146af to get more accurate results

@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
- Coverage   39.07%   37.54%   -1.54%     
==========================================
  Files          33       34       +1     
  Lines        4217     4392     +175     
==========================================
+ Hits         1648     1649       +1     
- Misses       2317     2502     +185     
+ Partials      252      241      -11     
Impacted Files Coverage Δ
server/cluster/cluster.go 0.00% <0.00%> (ø)
server/cluster/table_manager.go 0.00% <0.00%> (ø)
server/cluster/types.go 0.00% <0.00%> (ø)
server/coordinator/factory.go 0.00% <0.00%> (ø)
.../coordinator/procedure/create_table_common_util.go 0.00% <0.00%> (-70.50%) ⬇️
server/coordinator/procedure/util.go 0.00% <0.00%> (-38.89%) ⬇️
server/coordinator/scheduler.go 0.00% <0.00%> (ø)
...dml/createpartitiontable/create_partition_table.go 39.11% <35.29%> (ø)
...rdinator/procedure/dml/createtable/create_table.go 46.23% <46.23%> (ø)
.../coordinator/procedure/dml/droptable/drop_table.go 50.73% <50.73%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@archerny archerny changed the title Fix: add node state check in transfer leader procedure & Support multi-node concurrent shard opening. fix: add node state check in transfer leader procedure & Support multi-node concurrent shard opening. Feb 20, 2023
server/coordinator/scheduler.go Show resolved Hide resolved
server/service/http/error.go Outdated Show resolved Hide resolved
Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 merged commit 8caee7f into apache:main Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants