Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

refactor: error message in http api #180

Merged
merged 2 commits into from
May 24, 2023

Conversation

baojinri
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

error messages in http api are not detailed enough

What changes are included in this PR?

  • modify response error message
  • modify log error message

Are there any user-facing changes?

none

How does this change test

unit test & manual test

server/service/http/api.go Outdated Show resolved Hide resolved
server/service/http/api.go Outdated Show resolved Hide resolved
@ShiKaiWi ShiKaiWi changed the title refactor: refactor error message in http api refactor: error message in http api May 24, 2023
Copy link
Contributor

@ZuLiangWang ZuLiangWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZuLiangWang ZuLiangWang merged commit bf3e2f9 into apache:main May 24, 2023
4 checks passed
@baojinri baojinri deleted the refactor-api-error branch May 30, 2023 02:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants