Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

refactor: compatible with topology persistence #191

Merged
merged 6 commits into from
May 31, 2023

Conversation

ZuLiangWang
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

We modified the persistent data TopologyType in the previous pull request. In order to avoid the user from manually operating the interface, we need to add compatible code

What changes are included in this PR?

  • Add compatible code for TopologyType

Are there any user-facing changes?

Avoid users manually operating the interface to be compatible with version changes

How does this change test

An old version of the persistent data was used for testing in the local environment.

@ZuLiangWang ZuLiangWang changed the title refactor: Compatible with topology persistence refactor: compatible with topology persistence May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #191 (4b99389) into main (7f1354e) will increase coverage by 20.46%.
The diff coverage is 55.36%.

@@             Coverage Diff             @@
##             main     #191       +/-   ##
===========================================
+ Coverage   39.66%   60.12%   +20.46%     
===========================================
  Files          34       41        +7     
  Lines        4213     4918      +705     
===========================================
+ Hits         1671     2957     +1286     
+ Misses       2317     1581      -736     
- Partials      225      380      +155     
Impacted Files Coverage Δ
pkg/coderr/code.go 0.00% <ø> (ø)
server/cluster/metadata/types.go 0.00% <0.00%> (ø)
server/coordinator/procedure/util.go 0.00% <ø> (ø)
server/storage/meta.go 0.00% <ø> (ø)
server/storage/storage_impl.go 57.21% <0.00%> (-5.10%) ⬇️
server/member/watch_leader.go 40.62% <20.00%> (-2.71%) ⬇️
server/cluster/manager.go 39.02% <23.07%> (ø)
server/member/member.go 47.39% <45.00%> (-1.32%) ⬇️
server/coordinator/scheduler/scheduler_manager.go 53.96% <47.36%> (ø)
server/coordinator/procedure/manager_impl.go 73.68% <55.55%> (+73.68%) ⬆️
... and 13 more

... and 3 files with indirect coverage changes

@ZuLiangWang ZuLiangWang force-pushed the compatible_topology_persistence branch from 423c872 to d99e8f9 Compare May 30, 2023 12:06
server/server.go Outdated Show resolved Hide resolved
server/cluster/manager.go Show resolved Hide resolved
Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZuLiangWang ZuLiangWang merged commit 5726523 into apache:main May 31, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants