This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
feat: add least table shard picker #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
suggested changes
Oct 9, 2023
ZuLiangWang
force-pushed
the
uniform_shard_picker
branch
from
60ce982
to
b1a322a
Compare
ShiKaiWi
reviewed
Oct 9, 2023
ShiKaiWi
reviewed
Oct 9, 2023
ShiKaiWi
reviewed
Oct 9, 2023
ZuLiangWang
force-pushed
the
uniform_shard_picker
branch
2 times, most recently
from
b44d67b
to
35474cb
Compare
ZuLiangWang
force-pushed
the
uniform_shard_picker
branch
from
35474cb
to
28a940d
Compare
ShiKaiWi
approved these changes
Oct 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Currently, we use a completely random method to select shards for tables, which will lead to uneven distribution of tables in the cluster when the number of tables is small. In order to solve this problem, a new shardPicker is implemented, which selects the shard with the smallest number of current tables each time to create a table.
Detailed Changes
NewLeastTableShardPicker, which selects the shard with the smallest number of current tables each time to create a table.Test Plan