Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

chore: update golang to 1.19.1 #53

Merged
merged 4 commits into from
Sep 9, 2022
Merged

Conversation

ShiKaiWi
Copy link
Member

@ShiKaiWi ShiKaiWi commented Sep 9, 2022

Which issue does this PR close?

Closes #49

Rationale for this change

The style for doc comment has been updated with the go1.19 release, so some doc comments needs fixing.

What changes are included in this PR?

  • Update the go version to 1.19;
  • Fix some comment style;

Are there any user-facing changes?

None.

How does this change test

CI ensures this.

server/server.go Outdated Show resolved Hide resolved
server/storage/etcd_kv.go Outdated Show resolved Hide resolved
Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit 73b5970 into apache:main Sep 9, 2022
@ShiKaiWi ShiKaiWi deleted the fix-build-1.19-go branch September 9, 2022 07:37
ZuLiangWang pushed a commit to ZuLiangWang/ceresmeta that referenced this pull request Sep 13, 2022
* chore: update golang to 1.19.1

* chore: update golangci-lint to 1.49

* chore: fix comments

* chore: remove unnecessary nolint comment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fmt check failed in go 1.19
2 participants