Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

fix: fix some bugs by testing with ceresdb #85

Merged
merged 3 commits into from
Oct 25, 2022

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Oct 25, 2022

Which issue does this PR close?

Closes #

Rationale for this change

Fixed some bugs when testing with ceresdb clusters.

What changes are included in this PR?

  • Update shardTopology version when table is created or dropped
  • Refactor some error message
  • Refactor some code

Are there any user-facing changes?

No.

How does this change test

Manual testing.

@chunshao90 chunshao90 force-pushed the fix-some-bugs branch 3 times, most recently from 629e37e to 8146020 Compare October 25, 2022 10:05
@chunshao90 chunshao90 marked this pull request as ready for review October 25, 2022 11:46
server/cluster/cluster.go Outdated Show resolved Hide resolved
server/cluster/types.go Outdated Show resolved Hide resolved
server/cluster/types.go Outdated Show resolved Hide resolved
server/cluster/cluster.go Outdated Show resolved Hide resolved
server/cluster/cluster.go Outdated Show resolved Hide resolved
server/cluster/cluster.go Outdated Show resolved Hide resolved
server/cluster/cluster.go Show resolved Hide resolved
server/cluster/cluster.go Outdated Show resolved Hide resolved
server/cluster/cluster.go Outdated Show resolved Hide resolved
server/cluster/types.go Outdated Show resolved Hide resolved
server/coordinator/procedure/storage_impl.go Outdated Show resolved Hide resolved
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit eaa4d58 into apache:main Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants