This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
refactor: refactor storage of cluster meta data #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunshao90
force-pushed
the
refactor-meta-storage
branch
2 times, most recently
from
7dc0adb
to
0651cb0
Compare
chunshao90
force-pushed
the
refactor-meta-storage
branch
from
0651cb0
to
e7dc82c
Compare
chunshao90
changed the title
ZuLiangWang
reviewed
Nov 3, 2022
chunshao90
force-pushed
the
refactor-meta-storage
branch
from
73718e5
to
529a76c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Refer to #94
Rationale for this change
Refactor storage of cluster meta data, define the memory data structure corresponding to
pb.What changes are included in this PR?
Storageand renameMetaStoragetoStorageMetaStorageinterface by usingRequestandResultto avoid multi parameterspbAre there any user-facing changes?
No.
How does this change test
Old tests are covered.