chore: delete the configuration related to github cache #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanruixiang
force-pushed
the
test_without_cache_time
branch
from
6ae934e
to
a598961
Compare
tanruixiang
force-pushed
the
test_without_cache_time
branch
from
a598961
to
f810966
Compare
tanruixiang
changed the title
tanruixiang
changed the title
ShiKaiWi
reviewed
Oct 13, 2023
|
I plan to merge to main and see if it works well in daily dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Due to the huge cache of rust before, unit tests often failed due to insufficient capacity. CI without cache takes an acceptable time and does not cause failure problems.
#1261 show CI always fail in Rust Cache.
The github action's time seems have huge volatile, https://github.com/CeresDB/ceresdb/actions/runs/6517181839/job/17701414760?pr=1259 takes 24 min without cache, some pr have cache even is slower than this action
Detailed Changes
Delete out the configuration related to github cache
Test Plan
CI