feat: impl layered memtable to reduce duplicated encode during scan #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
changed the title
Rachelint
force-pushed
the
optimized-memtable
branch
from
25041c1
to
9583bac
Compare
Rachelint
changed the title
Rachelint
force-pushed
the
optimized-memtable
branch
2 times, most recently
from
05debba
to
9a165a5
Compare
|
@Rachelint Please fill in the content of the PR description. |
ShiKaiWi
reviewed
Dec 19, 2023
There was a problem hiding this comment.
@Rachelint Some basic unit tests are needed. And the comments needs polishing.
Rachelint
force-pushed
the
optimized-memtable
branch
2 times, most recently
from
74849fc
to
711feab
Compare
Rachelint
force-pushed
the
optimized-memtable
branch
from
0059a6a
to
d434821
Compare
Rachelint
force-pushed
the
optimized-memtable
branch
from
0e066b0
to
a1dec62
Compare
Rachelint
force-pushed
the
optimized-memtable
branch
2 times, most recently
from
5d4ba1e
to
afe28ce
Compare
Rachelint
force-pushed
the
optimized-memtable
branch
from
afe28ce
to
fc2ab02
Compare
ShiKaiWi
reviewed
Jan 8, 2024
Rachelint
force-pushed
the
optimized-memtable
branch
from
dcedb82
to
6afbee0
Compare
Rachelint
force-pushed
the
optimized-memtable
branch
from
6afbee0
to
171028d
Compare
ShiKaiWi
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Conversion from row format in memtable to record batch in datafusion has been found a cpu bottleneck in production. For reduce the cpu cost, I impl the layered memtable framework to support gradually conversion during normal write path(and before flush).
Detailed Changes
Test Plan
Test by new ut and it.