Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure primary key order #1292

Merged
merged 3 commits into from
Nov 6, 2023
Merged

fix: ensure primary key order #1292

merged 3 commits into from
Nov 6, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Nov 3, 2023 •
edited

Rationale

Current schema builder set primary_key_index inside add_key_column, which means key_indexes could only be in ascending order.

Detailed Changes

  • Remove nullable limit for pk
  • Refactor primary_key_index, user need to set it explicitly

Test Plan

Existing tests.

ShiKaiWi
ShiKaiWi reviewed Nov 3, 2023
View reviewed changes
common_types/src/schema.rs Outdated Show resolved Hide resolved
ShiKaiWi
ShiKaiWi reviewed Nov 6, 2023
View reviewed changes
common_types/src/schema.rs Outdated Show resolved Hide resolved
@jiacai2050 @ShiKaiWi
Update common_types/src/schema.rs
1e45833 
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
@jiacai2050 jiacai2050 merged commit 2cb70f7 into apache:main Nov 6, 2023
7 checks passed
@jiacai2050 jiacai2050 deleted the fix-null-pk-column branch November 6, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jiacai2050 @ShiKaiWi