-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edit: add schema id, schema name, catalog name in TableData #1294
Conversation
Actually, This is my current idea for the issue:
|
Ok, let me revise it |
I see this pr has conflicts with |
Just a moment, please. I'll sort it out😂 |
See codes again, and I found |
sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @dust1 . |
Rationale
Closes #1157
To be able to get the catalog from the table
Detailed Changes
I added the
schema id
,schema name
,catalog name
toMetaEditRequest
for passing them toTableData
, but becauseMetaEdit
involves passing the protoc protocol, I don't save them here.Test Plan
pass