Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unused min/max timestamp in the RowGroup #1297

Merged
merged 3 commits into from
Nov 7, 2023
Merged

refactor: remove unused min/max timestamp in the RowGroup #1297

merged 3 commits into from
Nov 7, 2023

Conversation

ShiKaiWi
Copy link
Member

@ShiKaiWi ShiKaiWi commented Nov 6, 2023

Rationale

The min/max timestamp in RowGroup is not used any more.

Detailed Changes

  • Remove the min/max timestamp from the RowGroup
  • Remove the RowGroupBuilder because it's too simple without min/max timestamp updating

Test Plan

All the tests in the CI should pass.

jiacai2050
jiacai2050 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit 617b166 into apache:main Nov 7, 2023
7 checks passed
@ShiKaiWi ShiKaiWi deleted the chore-remove-useless-code branch November 7, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShiKaiWi @jiacai2050