Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: impl priority runtime for read #1303

Merged
merged 27 commits into from
Dec 28, 2023
Merged

feat: impl priority runtime for read #1303

merged 27 commits into from
Dec 28, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Nov 8, 2023 •
edited

Rationale

Close #1299

Detailed Changes

  • Add PriorityRuntime component, and use in read API
    • In normal query, its plan will be executed in higher runtime by default, when executor decide query is expensive, then it will spawn stream.poll in another lower runtime.
    • In distributed query, a priority field is added in remote query request, so it can decide which runtime to run on.

Test Plan

Newly added UT

@jiacai2050 jiacai2050 force-pushed the feat-priority-rt branch 2 times, most recently from 8c5e4f2 to 72a5e6f Compare November 15, 2023 02:41
@jiacai2050 jiacai2050 mentioned this pull request Nov 27, 2023
Closed
16 tasks
@jiacai2050 jiacai2050 marked this pull request as ready for review November 27, 2023 10:32
@ShiKaiWi ShiKaiWi mentioned this pull request Dec 4, 2023
Closed
10 tasks
@jiacai2050 jiacai2050 changed the base branch from main to dev December 4, 2023 03:58
ShiKaiWi
ShiKaiWi reviewed Dec 12, 2023
View reviewed changes
components/runtime/src/priority_runtime.rs Outdated Show resolved Hide resolved
df_engine_extensions/src/dist_sql_query/resolver.rs Outdated Show resolved Hide resolved
docs/example-cluster-0.toml Outdated Show resolved Hide resolved
components/runtime/src/priority_runtime.rs Outdated Show resolved Hide resolved
Rachelint
Rachelint approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit ce4044b into apache:dev Dec 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi left review comments

@Rachelint Rachelint Rachelint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read runtime isolation
3 participants
@jiacai2050 @ShiKaiWi @Rachelint