Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: alter partition table tag column #1304

Merged
merged 5 commits into from
Nov 10, 2023
Merged

fix: alter partition table tag column #1304

merged 5 commits into from
Nov 10, 2023

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Nov 9, 2023 •
edited by jiacai2050

Rationale

Fix adding column in partition table bug.

Detailed Changes

  1. Checking the schema inconsistency error in the write process, caused by adding columns.
    • Note: This only works for grpc write
  2. Add a Go SDK test to check adding a column in a "partition table".
  3. Start ceresdb cluster to run go-sdk tests.

Test Plan

GO SDK test.

@chunshao90 chunshao90 marked this pull request as ready for review November 9, 2023 08:49
jiacai2050
jiacai2050 reviewed Nov 10, 2023
View reviewed changes
proxy/src/write.rs Outdated Show resolved Hide resolved
jiacai2050
jiacai2050 approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 718c230 into apache:main Nov 10, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chunshao90 @jiacai2050