feat: impl DoNothing wal #1311
Merged
feat: impl DoNothing wal #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
force-pushed
the
feat-dummy-data-wal
branch
from
1f538cf
to
10c5ca5
Compare
jiacai2050
force-pushed
the
feat-dummy-data-wal
branch
from
0f70c07
to
332dc53
Compare
Rachelint
reviewed
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
In some deployments when latest data is allowed to lost, wal is not a required module.
Also, wal may cost too much resources if write throughput is high, by disable it, we can save those resources.
Detailed Changes
DoNothingwal implementationWalConfig, and add a newdisable_dataflag in it.Configwrap oldStorageConfig, and use#[serde(flatten)]to keep backwards compatible.Test Plan
Manually