Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: normalize comments/doc in rustfmt #1335

Merged
merged 1 commit into from
Dec 4, 2023
Merged

style: normalize comments/doc in rustfmt #1335

merged 1 commit into from
Dec 4, 2023

Conversation

jackwener
Copy link
Member

@jackwener jackwener commented Dec 4, 2023 •
edited by tanruixiang

Rationale

make rustfmt more powerful

Detailed Changes

normalize comments/doc in rustfmt

Test Plan

style-check CI

tanruixiang
tanruixiang approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@tanruixiang tanruixiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thank you for your contribution, It will be merged after CI becomes green.

@jackwener
Copy link
Member Author

It looks like some unit tests are not stable.

@tanruixiang
Copy link
Member

This is a known unstable test, maybe need to reopen issue. #1241

@tanruixiang tanruixiang merged commit 6bcd930 into apache:main Dec 4, 2023
7 checks passed
@jackwener jackwener deleted the style branch December 4, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanruixiang tanruixiang tanruixiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jackwener @tanruixiang