-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(license): rename license-header.txt
's CeresDB to HoraeDB
#1336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks for your contribution.
license-header.txt
's CeresDB to HoraeDB
Do we still use this file? I wonder if we can just remove it. |
This is supposed to be used with a git hook, which some people may think use docker HawkEye is too heavy. |
Thank you for your reply, which just answered my doubts |
If we can use precommit to format license header, maybe we don't need HawkEye but just keep one tool. However, it may not desire time to investigate XD |
Good idea, then can we check the license header in the cli phase |
Yes, we can check in CI using the same way as precommit. But as you say, there's no need to spend time on that. Maybe someone can do that for fun in their spare time. 🤣 |
Or use shell command in precommit hooks to replace the |
create a issue. This hook's repo is https://github.com/Lucas-C/pre-commit-hooks, maybe you mean https://github.com/Lucas-C/pre-commit-hooks#handy-shell-functions? |
Rationale
Related #1319
Detailed Changes
update
license-header.txt
's orgTest Plan
UT.