Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(license): rename license-header.txt's CeresDB to HoraeDB #1336

Merged
merged 1 commit into from
Dec 4, 2023
Merged

chore(license): rename license-header.txt's CeresDB to HoraeDB #1336

merged 1 commit into from
Dec 4, 2023

Conversation

caicancai
Copy link
Member

@caicancai caicancai commented Dec 4, 2023

Rationale

Related #1319

Detailed Changes

update license-header.txt's org

Test Plan

UT.

@tanruixiang tanruixiang changed the title chore/license: rename CeresDB to HoraeDB chore(license): rename CeresDB to HoraeDB Dec 4, 2023
Copy link
Member

@tanruixiang tanruixiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for your contribution.

scripts/license-header.txt Show resolved Hide resolved
@tanruixiang tanruixiang changed the title chore(license): rename CeresDB to HoraeDB chore(license): rename license-header.txt's CeresDB to HoraeDB Dec 4, 2023
@tanruixiang tanruixiang merged commit 034ac75 into apache:main Dec 4, 2023
7 checks passed
@tisonkun
Copy link
Member

tisonkun commented Dec 4, 2023

Do we still use this file? I wonder if we can just remove it.

@caicancai caicancai deleted the typo branch December 4, 2023 04:42
@tanruixiang
Copy link
Member

Do we still use this file? I wonder if we can just remove it.

This is supposed to be used with a git hook, which some people may think use docker HawkEye is too heavy.
https://github.com/CeresDB/horaedb/blob/034ac75444c90e9c4317e0a032b9ee9636bd3a77/.pre-commit-config.yaml#L14

@caicancai
Copy link
Member Author

Do we still use this file? I wonder if we can just remove it.

This is supposed to be used with a git hook, which some people may think use docker HawkEye is too heavy.

https://github.com/CeresDB/horaedb/blob/034ac75444c90e9c4317e0a032b9ee9636bd3a77/.pre-commit-config.yaml#L14

Thank you for your reply, which just answered my doubts

@tisonkun
Copy link
Member

tisonkun commented Dec 4, 2023

If we can use precommit to format license header, maybe we don't need HawkEye but just keep one tool. However, it may not desire time to investigate XD

@caicancai
Copy link
Member Author

If we can use precommit to format license header, maybe we don't need HawkEye but just keep one tool. However, it may not desire time to investigate XD

Good idea, then can we check the license header in the cli phase

@tanruixiang
Copy link
Member

tanruixiang commented Dec 4, 2023

If we can use precommit to format license header, maybe we don't need HawkEye but just keep one tool. However, it may not desire time to investigate XD

Yes, we can check in CI using the same way as precommit.

But as you say, there's no need to spend time on that. Maybe someone can do that for fun in their spare time. 🤣

@tisonkun
Copy link
Member

tisonkun commented Dec 4, 2023

Or use shell command in precommit hooks to replace the insert-license hook since I don't find how the hooks can configure ..

@tanruixiang
Copy link
Member

Or use shell command in precommit hooks to replace the insert-license hook since I don't find how the hooks can configure ..

create a issue. This hook's repo is https://github.com/Lucas-C/pre-commit-hooks, maybe you mean https://github.com/Lucas-C/pre-commit-hooks#handy-shell-functions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants