Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure channel size non zero #1345

Merged
merged 3 commits into from
Dec 6, 2023
Merged

fix: ensure channel size non zero #1345

merged 3 commits into from
Dec 6, 2023

Conversation

jiacai2050
Copy link
Contributor

Rationale

When channel capacity < read_parallelism, we will pass 0 to channel, which will cause panic

2023-12-05 20:31:32.974 ERRO [components/panic_ext/src/lib.rs:54] thread 'ceres-read' panicked 'mpsc bounded channel requires buffer > 0' at "analytic_engine/src/sst/parquet/async_reader.rs:736"

Detailed Changes

  • Ensure channel size non zero

Test Plan

No need.

Rachelint
Rachelint approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 22b724c into apache:dev Dec 6, 2023
7 checks passed
@jiacai2050 jiacai2050 deleted the fix-chan-buf branch December 6, 2023 09:52
@jiacai2050 jiacai2050 restored the fix-chan-buf branch December 28, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rachelint Rachelint Rachelint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jiacai2050 @Rachelint