fix: no write stall #1388
Merged
fix: no write stall #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tisonkun @tanruixiang Would you please approve the workflow to run when it's convenient for you? |
|
merging.. |
ShiKaiWi
added a commit
to ShiKaiWi/ceresdb
that referenced
this pull request
Dec 22, 2023
small ssts, but the write stall is also removed in the normal write path. Introduce the `min_flush_interval` to avoid frequent flush requests and recover the write stall mechanism. Add unit tests for the frequent flush check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
#1003 tries to avoid frequent flush requests which may generate massive small ssts, but the write stall is also removed in the normal write path.
Detailed Changes
Introduce the
min_flush_intervalto avoid frequent flush requests and recover the write stall mechanism.Test Plan
Add unit tests for the frequent flush check.