Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add table status check #1418

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Conversation

ZuLiangWang
Copy link
Contributor

Rationale

Refer to this issue #1386, currently, if the status of the shard is abnormal, we cannot get any valid exception information from the error message table not found.

Detailed Changes

  • Add TableStatus in cluster, you can use it to get the status of the table in the current cluster..
  • Add SchemaWithCluster, It wraps the schema inside the cluster, through which the state of the cluster and schema can be combined.

Test Plan

Pass CI.

@ZuLiangWang ZuLiangWang force-pushed the table_not_found branch 7 times, most recently from 1a9fdcf to ec46e69 Compare January 3, 2024 03:37
@jiacai2050 jiacai2050 self-requested a review January 4, 2024 02:07
cluster/src/cluster_impl.rs Outdated Show resolved Hide resolved
cluster/src/cluster_impl.rs Outdated Show resolved Hide resolved
cluster/src/lib.rs Outdated Show resolved Hide resolved
cluster/src/shard_set.rs Outdated Show resolved Hide resolved
catalog/src/schema.rs Outdated Show resolved Hide resolved
cluster/src/lib.rs Outdated Show resolved Hide resolved
catalog/src/schema.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit dc10253 into apache:dev Jan 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants