Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add system_stats lib to collect system stats #1442

Merged
merged 3 commits into from
Jan 17, 2024
Merged

feat: add system_stats lib to collect system stats #1442

merged 3 commits into from
Jan 17, 2024

Conversation

ShiKaiWi
Copy link
Member

@ShiKaiWi ShiKaiWi commented Jan 16, 2024 •
edited

Rationale

Part of #1438. The preparations for reporting system statistics.

Detailed Changes

  • Add a new component called system_stats to helps collect system statistics.
  • Introduce a dependency sysinfo.

Test Plan

Add a new unit test.

ZuLiangWang
ZuLiangWang approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@ZuLiangWang ZuLiangWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit d7239ed into apache:main Jan 17, 2024
6 checks passed
@ShiKaiWi ShiKaiWi deleted the metrics-for-load branch January 17, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZuLiangWang ZuLiangWang ZuLiangWang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShiKaiWi @ZuLiangWang