refactor: refactor compaction process for remote compaction #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
changed the title
jiacai2050
reviewed
Feb 4, 2024
Rachelint
force-pushed
the
remote-compaction-pre-refactor
branch
from
046ac18
to
d5cb217
Compare
Rachelint
force-pushed
the
remote-compaction-pre-refactor
branch
from
2a08801
to
7ece79d
Compare
ShiKaiWi
approved these changes
Feb 27, 2024
zealchen
pushed a commit
to zealchen/incubator-horaedb
that referenced
this pull request
Apr 9, 2024
) ## Rationale The first step to support compaction offload apache#1480 ## Detailed Changes - Extract the common compaction logic to `CompactionExecutor`. - Define the `CompactionRunner` trait to support remote compaction after. - Define the `Compactor` to integration the new compaction logics, and insert them into main process. ## Test Plan Test manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The first step to support compaction offload #1480
Detailed Changes
CompactionExecutor.CompactionRunnertrait to support remote compaction after.Compactorto integration the new compaction logics, and insert them into main process.Test Plan
Test manually.