feat: support aliyun oss as object store backend #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
|
Four failing cases:
Update: all passed |
waynexia
changed the title
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
ShiKaiWi
reviewed
Jun 10, 2022
analytic_engine/src/setup.rs
Outdated
| path: sst_path.to_string_lossy().into_owned(), | ||
| })?; | ||
| LocalFileSystem::new_with_prefix(sst_path).context(OpenObjectStore) | ||
| async fn open_storage_local(config: Config) -> Result<LocalFileSystem> { |
There was a problem hiding this comment.
Is it better to use the struct in the StorageOptions::Local as the paramater of this function?
analytic_engine/src/setup.rs
Outdated
| } | ||
| } | ||
|
|
||
| async fn open_storage_aliyun(config: Config) -> Result<impl ObjectStore> { |
There was a problem hiding this comment.
Is it better to use the struct in the StorageOptions::Aliyun as the paramater of this function?
components/object_store/Cargo.toml
Outdated
| upstream = { package = "object_store", version = "0.1.0" } | ||
| # oss-rust-sdk = "0.4.0" | ||
| oss-rust-sdk = { git = "https://github.com/NoXF/oss-rust-sdk.git", rev = "260e6fc95e06739fc33927a8b575896088a65966" } | ||
| snafu = { version = "0.6.10", features = ["backtraces"] } |
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* feat: impl object store interface for aliyun oss Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * add storage options Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * license header Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * CR refines Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruihang Xia waynestxia@gmail.com
Which issue does this PR close?
Closes #19
Rationale for this change
See #19
What changes are included in this PR?
ObjectStoreimplementorAliyunOSSAre there any user-facing changes?
Config changed.
Removed:
analytical_engine::Config::data_pathAdded:
analytical_engine::Config::storageanalytical_engine::Config::wal_pathHow does this change test
Run unit test on a private aliyun OSS deployment.