[HUDI-196] First draft of committership guidelines #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vinothchandar
commented
Aug 2, 2019
vinothchandar
commented
- Minor details on JIRA usage
- Updated html files
|
All, please provide feedback |
n3nash
reviewed
Aug 4, 2019
n3nash
reviewed
Aug 4, 2019
n3nash
reviewed
Aug 4, 2019
|
left 2 comments, rest looks good to me |
bvaradar
approved these changes
Aug 5, 2019
yanghua
reviewed
Aug 6, 2019
| @@ -35,6 +35,7 @@ Here's a typical lifecycle of events to contribute to Hudi. | |||
| - [Optional] If you want to get involved, but don't have a project in mind, please check JIRA for small, quick-starters. | |||
| - [Optional] Familiarize yourself with internals of Hudi using content on this page, as well as [wiki](https://cwiki.apache.org/confluence/display/HUDI) | |||
| - Once you finalize on a project/task, please open a new JIRA or assign an existing one to yourself. (If you don't have perms to do this, please email the dev mailing list with your JIRA id and a small intro for yourself. We'd be happy to add you as a contributor) | |||
| - Almost all PRs should be linked to a JIRA. Before you begin work, click "Start Progress" on the JIRA, which tells everyone that you are working on the issue actively. | |||
There was a problem hiding this comment.
Maybe we could add a good practice like this
Before you start working, if you are unsure about the solution, you can seek a committer as a mentor and participate in the discussion.
I think this is a more efficient way of working with the community.
There was a problem hiding this comment.
https://hudi.apache.org/contributing.html already covers this IMO?
- Minor details on JIRA usage - Updated html files
vinothchandar
force-pushed
the
asf-site-committership-guidelines
branch
from
441f9c1
to
f0946bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.