fix: base-ref/head-ref missed in dependency-check-ci on branch push #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon824
reviewed
Oct 24, 2023
| push: | ||
| branches: | ||
| - main | ||
| - 'release-*' |
There was a problem hiding this comment.
keep consistent with the hugegraph?
https://github.com/apache/incubator-hugegraph/blob/d4b95ca32371dfdee60d448fa3e5ab38fc4e288e/.github/workflows/check-dependencies.yml#L6
There was a problem hiding this comment.
Thanks, i'll take a look, just ref: apache/incubator-hugegraph-toolchain#516 before.
There was a problem hiding this comment.
Thanks, i'll take a look, just ref: apache/incubator-hugegraph-toolchain#516 before.
The reason is the running ci context is a little different, we need Check License Header in push action but don't need with Dependency Review, so consider:
- just remove
pushaction like this - separate them for different trigger logic (may need check the action doc) OR just divide into 2 CI files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer to apache/incubator-hugegraph#2308