Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add auth&metric&traverser&task api and ut #28

Merged
merged 25 commits into from Feb 25, 2024

Conversation

simon824
Copy link
Member

add ut & pyhugegraph code format

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jan 25, 2024
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jan 29, 2024
@simon824 simon824 changed the title feat: add ut & pyhugegraph code format feat: add auth&metric&traverser&task api and ut Jan 29, 2024
@simon824
Copy link
Member Author

simon824 commented Feb 2, 2024

@imbajin @Zony7 @liuxiaocs7 @javeme please take a review when free, thanks!

Copy link
Member

@liuxiaocs7 liuxiaocs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that there are two forms of test code in UT, as shown below, should they be standardized into one?

assert 4 == len(schema)

self.assertEqual(len(all_basic_metrics), 5)

Copy link

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@liuxiaocs7 liuxiaocs7 merged commit f767a5e into apache:main Feb 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants