New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact(common): add more construction methods for convenient #132
Conversation
thanks,maybe change the merge branch to master? @VGalaxies all need meet? |
All the required ctors are now in place 🎈 |
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
=========================================
Coverage 93.15% 93.15%
Complexity 65 65
=========================================
Files 9 9
Lines 263 263
Branches 22 22
=========================================
Hits 245 245
Misses 8 8
Partials 10 10 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
this.name = name; | ||
this.listeners = new ConcurrentHashMap<>(); | ||
EventHub.init(1); | ||
} | ||
|
||
public EventHub(String name, int threadSize) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just let EventHub(String name)
call EventHub(name, 1)
@@ -43,6 +43,12 @@ public RestResult(Response response) { | |||
this.content = response.readEntity(String.class); | |||
} | |||
|
|||
public RestResult(int status, String content, MultivaluedMap<String, Object> headers) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
bc4f46f
to
c4d5603
Compare
add some construction methods for more convenient use