Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve number of transport threads and max_timeout_heartbeat_count #103

Merged
merged 9 commits into from Sep 26, 2021
Merged

improve number of transport threads and max_timeout_heartbeat_count #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fde906f
improve number of transport threads
coderzc Sep 15, 2021
f410ed2
improve number of transport threads
coderzc Sep 15, 2021
e94adb3
improve number of transport threads
coderzc Sep 15, 2021
55a612d
improve number of transport threads
coderzc Sep 15, 2021
3a5dab2
rollback
coderzc Sep 15, 2021
42dd8a8
improve clientThreads
coderzc Sep 15, 2021
9876c37
improve code style
coderzc Sep 15, 2021
9c652d8
only use readerIdleTime for server
coderzc Sep 17, 2021
e1baca9
improve maxTransportThreads
coderzc Sep 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 3 additions & 5 deletions computer-core/src/main/java/com/baidu/hugegraph/computer/core/config/ComputerOptions.java
View file
Open in desktop
Expand Up @@ -516,17 +516,15 @@ public static synchronized ComputerOptions instance() {
public static final ConfigOption<Integer> TRANSPORT_SERVER_THREADS =
new ConfigOption<>(
"transport.server_threads",
"The number of transport threads for server, the default " +
"value is CPUs.",
"The number of transport threads for server.",
positiveInt(),
TransportConf.NUMBER_CPU_CORES
);

public static final ConfigOption<Integer> TRANSPORT_CLIENT_THREADS =
new ConfigOption<>(
"transport.client_threads",
"The number of transport threads for client, the default " +
"value is CPUs.",
"The number of transport threads for client.",
positiveInt(),
TransportConf.NUMBER_CPU_CORES
);
Expand Down Expand Up @@ -718,7 +716,7 @@ public static synchronized ComputerOptions instance() {
"response continuously > max_heartbeat_timeouts the " +
"channel will be closed from client side.",
positiveInt(),
90
120
);

public static final ConfigOption<Long> HGKV_MAX_FILE_SIZE =
Expand Down
17 changes: 12 additions & 5 deletions computer-core/src/main/java/com/baidu/hugegraph/computer/core/network/TransportConf.java
View file
Open in desktop
Expand Up @@ -32,12 +32,11 @@
public class TransportConf {

public static final String SERVER_THREAD_GROUP_NAME =
"hugegraph-netty-server";
"transport-netty-server";
public static final String CLIENT_THREAD_GROUP_NAME =
"hugegraph-netty-client";
"transport-netty-client";
public static final int NUMBER_CPU_CORES =
Runtime.getRuntime().availableProcessors();

private final Config config;

public static TransportConf wrapConfig(Config config) {
Expand All @@ -63,13 +62,21 @@ public int serverPort() {
public int serverThreads() {
return Math.min(
this.config.get(ComputerOptions.TRANSPORT_SERVER_THREADS),
this.config.get(ComputerOptions.JOB_WORKERS_COUNT));
this.maxTransportThreads());
}

public int clientThreads() {
return Math.min(
this.config.get(ComputerOptions.TRANSPORT_CLIENT_THREADS),
this.config.get(ComputerOptions.JOB_WORKERS_COUNT));
this.maxTransportThreads());
}

private int maxTransportThreads() {
Integer workerCount = this.config
.get(ComputerOptions.JOB_WORKERS_COUNT);
Integer partitions = this.config
.get(ComputerOptions.JOB_PARTITIONS_COUNT);
return partitions / workerCount + 1;
}

public TransportProvider transportProvider() {
Expand Down
4 changes: 2 additions & 2 deletions ...ter-core/src/main/java/com/baidu/hugegraph/computer/core/network/netty/NettyProtocol.java
View file
Open in desktop
Expand Up @@ -185,8 +185,8 @@ private NettyServerHandler newNettyServerHandler(MessageHandler handler) {

private IdleStateHandler newServerIdleStateHandler() {
long timeout = this.conf.serverIdleTimeout();
return new IdleStateHandler(DISABLE_IDLE_TIME, DISABLE_IDLE_TIME,
timeout, TimeUnit.MILLISECONDS);
return new IdleStateHandler(timeout, DISABLE_IDLE_TIME,
DISABLE_IDLE_TIME, TimeUnit.MILLISECONDS);
}

private IdleStateHandler newClientIdleStateHandler() {
Expand Down