Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update PULL_REQUEST_TEMPLATE.md #257

Merged
merged 3 commits into from Jun 25, 2023

Conversation

Radeity
Copy link
Member

@Radeity Radeity commented Jun 21, 2023

Purpose of the PR

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

Co-authored-by: imbajin <jin@apache.org>
imbajin
imbajin previously approved these changes Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #257 (90e556c) into master (024d1aa) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #257   +/-   ##
=========================================
  Coverage     85.86%   85.86%           
  Complexity     3235     3235           
=========================================
  Files           344      344           
  Lines         12115    12115           
  Branches       1092     1092           
=========================================
  Hits          10402    10402           
  Misses         1190     1190           
  Partials        523      523           

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imbajin imbajin merged commit 510d7f9 into apache:master Jun 25, 2023
7 checks passed
@Radeity Radeity deleted the update-pr-template branch July 12, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants