Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): io.grpc.grpc-core dependency conflict #296

Merged
merged 1 commit into from Dec 16, 2023

Conversation

diaohancai
Copy link
Contributor

Purpose of the PR

Main Changes

Exclude io.grpc.grpc-core low version dependency.

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows.
    Submit any one algorithm job to k8s and job could be successfully executed.

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (e0b484a) 85.03% compared to head (ba3d44c) 84.97%.
Report is 3 commits behind head on master.

Files Patch % Lines
...apache/hugegraph/computer/core/bsp/EtcdClient.java 52.38% 6 Missing and 4 partials ⚠️
.../hugegraph/computer/core/worker/WorkerService.java 85.93% 8 Missing and 1 partial ⚠️
.../hugegraph/computer/core/master/MasterService.java 50.00% 4 Missing and 3 partials ⚠️
...raph/computer/k8s/operator/OperatorEntrypoint.java 81.81% 2 Missing ⚠️
...h/computer/core/network/session/ClientSession.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #296      +/-   ##
============================================
- Coverage     85.03%   84.97%   -0.06%     
- Complexity     3296     3302       +6     
============================================
  Files           349      349              
  Lines         12485    12500      +15     
  Branches       1130     1132       +2     
============================================
+ Hits          10616    10622       +6     
- Misses         1329     1339      +10     
+ Partials        540      539       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javeme javeme merged commit 358aafc into apache:master Dec 16, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] NoClassDefFoundError: io/grpc/InternalConfigSelector
3 participants