output demo(pagerank) #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
============================================
- Coverage 88.10% 87.58% -0.52%
- Complexity 2632 2685 +53
============================================
Files 270 281 +11
Lines 9926 10206 +280
Branches 836 847 +11
============================================
+ Hits 8745 8939 +194
- Misses 770 850 +80
- Partials 411 417 +6
Continue to review full report at Codecov.
|
zhoney
force-pushed
the
pagerank-output
branch
9 times, most recently
from
ff29dab
to
e2fd20d
Compare
coderzc
requested changes
Aug 10, 2021
Comment on lines
+220
to
+268
| public static final ConfigOption<Integer> OUTPUT_BATCH_SIZE = | ||
| new ConfigOption<>( | ||
| "output.batch_size", | ||
| "The batch size of output", | ||
| positiveInt(), | ||
| 500 | ||
| ); | ||
|
|
||
| public static final ConfigOption<Integer> OUTPUT_BATCH_THREADS = | ||
| new ConfigOption<>( | ||
| "output.batch_threads", | ||
| "The threads number used to batch output", | ||
| positiveInt(), | ||
| 1 | ||
| ); | ||
|
|
||
| public static final ConfigOption<Integer> OUTPUT_SINGLE_THREADS = | ||
| new ConfigOption<>( | ||
| "output.single_threads", | ||
| "The threads number used to single output", | ||
| positiveInt(), | ||
| 1 | ||
| ); | ||
|
|
||
| public static final ConfigOption<Integer> | ||
| OUTPUT_THREAD_POOL_SHUTDOWN_TIMEOUT = | ||
| new ConfigOption<>( | ||
| "output.thread_pool_shutdown_timeout", | ||
| "The timeout seconds of output threads pool shutdown", | ||
| positiveInt(), | ||
| 60 | ||
| ); | ||
|
|
||
| public static final ConfigOption<Integer> OUTPUT_RETRY_TIMES = | ||
| new ConfigOption<>( | ||
| "output.retry_times", | ||
| "The retry times when output failed", | ||
| positiveInt(), | ||
| 3 | ||
| ); | ||
|
|
||
| public static final ConfigOption<Integer> OUTPUT_RETRY_INTERVAL = | ||
| new ConfigOption<>( | ||
| "output.retry_interval", | ||
| "The retry interval when output failed", | ||
| positiveInt(), | ||
| 10 | ||
| ); | ||
|
|
zhoney
force-pushed
the
pagerank-output
branch
from
e2fd20d
to
671962e
Compare
javeme
reviewed
Aug 17, 2021
| positiveInt(), | ||
| Integer.class | ||
| ); | ||
|
|
There was a problem hiding this comment.
can move some options of ComputerOptions to api module?
zhoney
force-pushed
the
pagerank-output
branch
from
c0aeb86
to
3ed4b67
Compare
Linary
approved these changes
Aug 26, 2021
corgiboygsj
approved these changes
Aug 26, 2021
javeme
reviewed
Aug 26, 2021
| @@ -42,6 +42,6 @@ public void setAlgorithmParameters(Map<String, String> params) { | |||
| this.setIfAbsent(params, ComputerOptions.WORKER_COMBINER_CLASS, | |||
| DoubleValueSumCombiner.class.getName()); | |||
| this.setIfAbsent(params, ComputerOptions.OUTPUT_CLASS, | |||
| LimitedLogOutput.class.getName()); | |||
| PageRankOutput.class.getName()); | |||
There was a problem hiding this comment.
need to update other algorithms?
| "output.retry_interval", | ||
| positiveInt(), | ||
| Integer.class | ||
| ); |
There was a problem hiding this comment.
can move some options of ComputerOptions to api module?
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-lang3</artifactId> | ||
| <version>3.9</version> | ||
| </dependency> |
There was a problem hiding this comment.
seems it's included by hugegraph-common
There was a problem hiding this comment.
The version depended by hugegraph-common is low, so need to include explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.