Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update gremlin config in graphs.md #282

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Conversation

badagou333
Copy link
Contributor

@badagou333 badagou333 commented Sep 12, 2023

fix #285

line126:
gremlin.graph=org.apache.hugegraph.auth.HugeFactoryAuthProxy

line126:
gremlin.graph=org.apache.hugegraph.auth.HugeFactoryAuthProxy
@@ -123,7 +123,7 @@ POST http://localhost:8080/graphs/hugegraph2
##### Request Body

```
gremlin.graph=com.baidu.hugegraph.auth.HugeFactoryAuthProxy
gremlin.graph=org.apache.hugegraph.auth.HugeFactoryAuthProxy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX, could u also help update the English version?

@imbajin imbajin changed the title Update graphs.md doc: update gremlin config in graphs.md Sep 13, 2023
@imbajin imbajin linked an issue Sep 14, 2023 that may be closed by this pull request
@imbajin
Copy link
Member

imbajin commented Sep 14, 2023

Could also fix the linked issue? THX (Update: I have already fixed them)

Some suggestion for all people:
Install AutoCorrect plugin first (thanks for @VGalaxies mentioned it)

image image

and a grammar check plugin:

image

Could comment any other nice plugin to auto-format the doc/code 🔢

@imbajin imbajin merged commit 3baae60 into apache:master Sep 18, 2023
1 check passed
github-actions bot pushed a commit that referenced this pull request Sep 18, 2023
line126:
gremlin.graph=org.apache.hugegraph.auth.HugeFactoryAuthProxy

* enhance a string of style problem & fix package name

---------

Co-authored-by: imbajin <jin@apache.org> 3baae60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve] update path from com.baidu to org.apache
2 participants