Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Unify & clean code style in hubble & client #591

Closed
9 of 16 tasks
returnToInnocence opened this issue Mar 18, 2024 · 1 comment
Closed
9 of 16 tasks
Labels
enhancement New feature or request feature hubble hugegraph-hubble

Comments

@returnToInnocence
Copy link
Contributor

returnToInnocence commented Mar 18, 2024

SubTask

PS: Since the changes and logic involved are not complex, it is done in one PR according to the way different subtasks commit

  • hubble-be format & clean task

    • Correct the copyright format.
      • .py copyright formatting standards need further discussion
        This is due to the File | Settings | Editor | Code Style in IDEA does not include the python files
        My personal thoughts (refer to apache-airflow), copyright and .editorconfig:
        1. indent_size = 4
        2. max_line_length = 110
        3. copyright style in .py may looks like apache-airflow's python file
      • other files
    • Format the hubble-be module
      • File type .java
      • File type .xml
      • File type .properties
      • .py formatting standards need further discussion
        This is due to the File | Settings | Editor | Copyright | Formatting in IDEA does not include the python files
    • Clean up the code.
  • hubble-fe format & clean task

    • Formatting standards may require further investigation and discussion
  • client format & clean task

  • loader format & clean task

  • spark-connector format & clean task

  • tools format & clean task

Related PR

  1. chore(hubble): Enhance code style in hubble #592
Copy link

dosubot bot commented Mar 18, 2024

It seems like you've got this under control, if you want help or have specific questions, let me know what I can do for you!

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@dosubot dosubot bot added enhancement New feature or request hubble hugegraph-hubble labels Mar 18, 2024
@imbajin imbajin changed the title [Summary] Enhance code style in hubble [Enhancement] Unify & clean code style in hubble Mar 19, 2024
@returnToInnocence returnToInnocence changed the title [Enhancement] Unify & clean code style in hubble [Enhancement] Unify & clean code style in hubble & client Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature hubble hugegraph-hubble
Projects
None yet
Development

No branches or pull requests

1 participant