Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hubble): Enhance code style in hubble #592

Merged
merged 13 commits into from Mar 19, 2024

Conversation

returnToInnocence
Copy link
Contributor

@returnToInnocence returnToInnocence commented Mar 18, 2024

Purpose of the PR

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@github-actions github-actions bot added the hubble hugegraph-hubble label Mar 18, 2024
optimize import, indentation, space adjustment
optimize import, indentation, space adjustment
optimize import, indentation, space adjustment
optimize import, indentation, space adjustment
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.41%. Comparing base (b066b80) to head (110cd1e).
Report is 27 commits behind head on master.

❗ Current head 110cd1e differs from pull request most recent head 7bf19b2. Consider uploading reports for the commit 7bf19b2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #592      +/-   ##
============================================
- Coverage     62.49%   62.41%   -0.08%     
- Complexity     1903     1931      +28     
============================================
  Files           262      267       +5     
  Lines          9541     9739     +198     
  Branches        886      891       +5     
============================================
+ Hits           5963     6079     +116     
- Misses         3190     3267      +77     
- Partials        388      393       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pom.xml Outdated Show resolved Hide resolved
hugegraph-hubble/hubble-fe/node/node.exe Outdated Show resolved Hide resolved
@returnToInnocence returnToInnocence marked this pull request as ready for review March 19, 2024 10:26
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. java Pull requests that update Java code labels Mar 19, 2024
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 19, 2024
@JackyYangPassion JackyYangPassion merged commit fd11c1a into apache:master Mar 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hubble hugegraph-hubble java Pull requests that update Java code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants