fix: hugegraph-spark-loader shell string length limit #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix:apache#460 I have read the CLA Document and I hereby sign the CLA
imbajin
changed the title
Codecov Report
@@ Coverage Diff @@
## master #469 +/- ##
============================================
- Coverage 62.52% 62.51% -0.02%
+ Complexity 1867 894 -973
============================================
Files 260 91 -169
Lines 9425 4396 -5029
Branches 873 516 -357
============================================
- Hits 5893 2748 -3145
+ Misses 3150 1445 -1705
+ Partials 382 203 -179 see 169 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@imbajin hi bro, Do I need to fix this error check? |
imbajin
reviewed
May 19, 2023
| @@ -35,4 +35,4 @@ CMD="${SPARK_HOME}/bin/spark-submit | |||
| --jars $(echo "${LIB_DIR}"/*.jar | tr ' ' ',') ${ASSEMBLY_JAR_NAME} ${HUGEGRAPH_PARAMS}" | |||
|
|
|||
| echo "${CMD}" | |||
| exec "${CMD}" | |||
| exec ${CMD} | |||
Nope If u mean this |
imbajin
approved these changes
May 19, 2023
liuxiaocs7
approved these changes
May 19, 2023
|
Hi, @gaoyuan5251, you could refer this to link pr with associated issue, once the pr is merged the issue will be closed automatically. Currently with a little syntax mistake: (should be |
|
Do I need to repush it? Or just wait for pr to merge? @liuxiaocs7 |
simon824
approved these changes
May 22, 2023
gaoyuan5251
added a commit
to gaoyuan5251/incubator-hugegraph-toolchain
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #460
I have read the CLA Document and I hereby sign the CLA