Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hubble): build not find CI locally #585

Closed
wants to merge 3 commits into from

Conversation

liuxiaocs7
Copy link
Member

@liuxiaocs7 liuxiaocs7 commented Mar 7, 2024

Purpose of the PR

In this pr: #543 (comment), we add CI=false && but build fails locally in windows.

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. ci Continuous integration hubble hugegraph-hubble labels Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.61%. Comparing base (b066b80) to head (8bbca88).
Report is 25 commits behind head on master.

❗ Current head 8bbca88 differs from pull request most recent head 5fc7dd0. Consider uploading reports for the commit 5fc7dd0 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #585      +/-   ##
============================================
+ Coverage     62.49%   62.61%   +0.11%     
+ Complexity     1903      993     -910     
============================================
  Files           262      174      -88     
  Lines          9541     5168    -4373     
  Branches        886      359     -527     
============================================
- Hits           5963     3236    -2727     
+ Misses         3190     1752    -1438     
+ Partials        388      180     -208     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liuxiaocs7 liuxiaocs7 closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration hubble hugegraph-hubble size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant